Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E083011F20 for ; Tue, 23 Sep 2014 04:44:34 +0000 (UTC) Received: (qmail 40347 invoked by uid 500); 23 Sep 2014 04:44:34 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 40316 invoked by uid 500); 23 Sep 2014 04:44:34 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 40302 invoked by uid 99); 23 Sep 2014 04:44:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Sep 2014 04:44:34 +0000 Date: Tue, 23 Sep 2014 04:44:34 +0000 (UTC) From: "Jason Brown (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-7978) CrcCheckChance should not be stored as part of an sstable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-7978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144324#comment-14144324 ] Jason Brown commented on CASSANDRA-7978: ---------------------------------------- I was slightly concerned about the unexpected appearance of the CFMD that's only used in one place, and hoped we could maybe get around that (as well as reducing the scope of CP's dependencies). You are correct that we need some wrapper to get those updates, and I just now spent time trying to see if it's just easier to pass the CFMD instance into the CP constructor (and always have a reference to that CFMD, rather than waiting for SSTR.getCompressionMetadata()). Unfortunately, it's not simple as CP has 4 constructors, called from different paths, and being able to pass the correct CFMD instance to those is not overly friendly. So, I'll stop making noise now and let you commit the patch so we can move on :). > CrcCheckChance should not be stored as part of an sstable > --------------------------------------------------------- > > Key: CASSANDRA-7978 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7978 > Project: Cassandra > Issue Type: Improvement > Reporter: sankalp kohli > Assignee: T Jake Luciani > Priority: Minor > Fix For: 2.0.11 > > Attachments: 7978.txt, 7978v2.txt > > > CrcCheckChance is stored with compression parameters in the sstable. The only way to change it is to do upgrade sstable. I don't see why it should not be a hot property. -- This message was sent by Atlassian JIRA (v6.3.4#6332)