Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Fri, 19 Sep 2014 21:14:37 +0000 (UTC)
From: "Benedict (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12741281.1410641658000.81597.1411161277007@Atlassian.JIRA>
In-Reply-To: <JIRA.12741281.1410641658000@Atlassian.JIRA>
References: <JIRA.12741281.1410641658000@Atlassian.JIRA>
 <JIRA.12741281.1410641658111@arcas>
Subject: [jira] [Commented] (CASSANDRA-7930) Warn when evicting prepared
 statements from cache
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141311#comment-14141311 ] 

Benedict commented on CASSANDRA-7930:
-------------------------------------

I think it would be good practice to move any executor that is shared across classes to a common location anyway. So +1 to doing that. Any executor that's used exclusively _for execution_ by the declaring class should probably stay where it is IMO. So anything that can be made "private static" should be. Gossiper already fits this bill, and BatchlogManager looks to me like, since it's only accessed externally to shutdown, it should simply have a static shutdown() method exposed that encapsulates this.

> Warn when evicting prepared statements from cache
> -------------------------------------------------
>
>                 Key: CASSANDRA-7930
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7930
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Robbie Strickland
>            Assignee: Robbie Strickland
>              Labels: bootcamp, jmx
>             Fix For: 2.1.1
>
>         Attachments: cassandra-2.0-v2.txt, cassandra-2.0-v3.txt, cassandra-2.0-v4.txt, cassandra-2.0-v5.txt, cassandra-2.0-v6.txt, cassandra-2.0.txt, cassandra-2.1.txt
>
>
> The prepared statement cache is an LRU, with a max size of maxMemory / 256.  There is currently no warning when statements are evicted, which could be problematic if the user is unaware that this is happening.
> At the very least, we should provide a JMX metric and possibly a log message indicating this is happening.  At some point it may also be worthwhile to make this tunable for users with large numbers of statements.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)