Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2803F11162 for ; Sat, 13 Sep 2014 19:43:34 +0000 (UTC) Received: (qmail 44754 invoked by uid 500); 13 Sep 2014 19:43:34 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 44716 invoked by uid 500); 13 Sep 2014 19:43:34 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 44653 invoked by uid 99); 13 Sep 2014 19:43:33 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 13 Sep 2014 19:43:33 +0000 Date: Sat, 13 Sep 2014 19:43:33 +0000 (UTC) From: "John Sumsion (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-7927) Kill daemon on any disk error MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-7927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sumsion updated CASSANDRA-7927: ------------------------------------ Attachment: 7927-v1-die.patch has unit tests for the commitlog part, but couldn't find any good way to unit test FileUtil without plowing a lot of ground, but kept changes in FileUtil DRYish > Kill daemon on any disk error > ----------------------------- > > Key: CASSANDRA-7927 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7927 > Project: Cassandra > Issue Type: New Feature > Components: Core > Environment: aws, stock cassandra or dse > Reporter: John Sumsion > Fix For: 2.1.1 > > Attachments: 7927-v1-die.patch > > > We got a disk read error on 1.2.13 that didn't trigger the disk failure policy, and I'm trying to hunt down why, but in doing so, I saw that there is no disk_failure_policy option for just killing the daemon. > If we ever get a corrupt sstable, we want to replace the node anyway, because some aws instance store disks just go bad. > I want to use the JVMStabilityInspector from CASSANDRA-7507 to kill so that remains standard, so I will base my patch on CASSANDRA-7507. -- This message was sent by Atlassian JIRA (v6.3.4#6332)