Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1152E1167F for ; Sat, 13 Sep 2014 06:25:34 +0000 (UTC) Received: (qmail 81742 invoked by uid 500); 13 Sep 2014 06:25:33 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 81705 invoked by uid 500); 13 Sep 2014 06:25:33 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 81694 invoked by uid 99); 13 Sep 2014 06:25:33 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 13 Sep 2014 06:25:33 +0000 Date: Sat, 13 Sep 2014 06:25:33 +0000 (UTC) From: "Branimir Lambov (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-7915) Waiting for sync on the commit log could happen after writing to memtable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-7915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132570#comment-14132570 ] Branimir Lambov commented on CASSANDRA-7915: -------------------------------------------- You're right, I didn't realize early availability could be a problem. Maybe we could still prepare the write and delay attaching it to the table, but that would be much more complicated and most probably not worth the effort. > Waiting for sync on the commit log could happen after writing to memtable > ------------------------------------------------------------------------- > > Key: CASSANDRA-7915 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7915 > Project: Cassandra > Issue Type: Improvement > Components: Core > Reporter: Branimir Lambov > Priority: Minor > > Currently the sync wait is part of CommitLog.add, which is executed in whole before any memtable write. The time for executing the latter is thus added on top of the time for file sync, which seems unnecessary. > Moving the wait to a call at the end of Keystore.apply should hide the memtable write time and may improve performance, especially for the batch sync strategy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)