Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 693FC1120A for ; Tue, 2 Sep 2014 15:03:21 +0000 (UTC) Received: (qmail 12011 invoked by uid 500); 2 Sep 2014 15:03:21 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 11973 invoked by uid 500); 2 Sep 2014 15:03:21 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 11962 invoked by uid 99); 2 Sep 2014 15:03:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Sep 2014 15:03:21 +0000 Date: Tue, 2 Sep 2014 15:03:21 +0000 (UTC) From: "Blake Eggleston (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-7840) Refactor static state & functions into static singletons MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-7840?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 14118256#comment-14118256 ]=20 Blake Eggleston commented on CASSANDRA-7840: -------------------------------------------- [~yukim] sure, here you go: https://github.com/bdeggleston/cassandra/tree/C= 7840. Moving the SystemKeyspace CFMetaData definitions off of the CFMetaData clas= s may end up causing more problems than it solves, so I may end up revertin= g it. > Refactor static state & functions into static singletons > -------------------------------------------------------- > > Key: CASSANDRA-7840 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7840 > Project: Cassandra > Issue Type: Sub-task > Reporter: Blake Eggleston > Labels: patch > Attachments: 0001-splitting-StorageService-executors-into-a-separ= ate-c.patch, 0002-making-DatabaseDescriptor-a-singleton.patch, 0003-refacto= ring-StorageService-static-methods.patch, 0004-making-StorageProxy-a-single= ton.patch, 0005-making-MigrationManager-a-singleton.patch, 0006-making-Syst= emKeyspace-a-singleton.patch, 0007-making-Auth-a-singleton.patch, 0008-remo= ving-static-methods-and-initialization-from-Comp.patch, 0009-making-SinkMan= ager-a-singleton.patch, 0010-making-DefsTables-a-singleton.patch, 0011-maki= ng-StageManager-a-singleton.patch, 0012-making-MessagingService-a-singleton= .patch, 0013-making-QueryProcessor-a-singleton.patch, 0014-refactoring-stat= ic-methods-on-Tracing.patch, 0015-removing-static-state-from-BatchlogManage= r.patch, 0016-removing-static-method-from-CommitLog.patch, 0017-OutboundTcp= Connection-removing-singleton-access-from.patch, 0018-FBUtilities-removing-= getLocalAddress-getBroadcastAdd.patch, 0019-PendingRangeCalculatorService-r= emoving-singleton-acc.patch, 0020-ActiveRepairService-removing-static-membe= rs-and-meth.patch, 0021-RowDataResolver-removing-static-singleton-access-fr= o.patch, 0022-AbstractReadExecutor-removing-static-method.patch, 0023-Stora= geServiceAccessor-removing-static-singleton-acc.patch, 0024-FileUtils-remov= ing-static-singleton-accesses-from-st.patch, 0025-ResourceWatcher-removing-= static-singleton-access-fro.patch, 0026-TokenMetadata-removing-static-singl= eton-access-from-.patch, 0027-OutboundTcpConnectionPool-removing-static-sin= gleton-.patch, 0028-Cassandra-PasswordAuthenticator-making-static-method.pa= tch, 0029-CompactionMetrics-making-static-method-instance-meth.patch, 0030-= ClientState-splitting-configured-QueryHandler-instan.patch, 0031-SSTableRea= der-splitting-static-factory-methods-into-.patch, 0032-Keyspace-splitting-s= tatic-factory-methods-and-state-.patch, 0033-ColumnFamilyStore-splitting-st= atic-factory-methods-a.patch, 0034-TriggerDefinition-removing-static-single= ton-access-f.patch, 0035-CFMetaData-splitting-off-static-factory-methods-on= to.patch, 0036-KSMetaData-splitting-off-static-factory-methods-onto.patch, = 0037-SystemKeyspace-moving-system-keyspace-definitions-on.patch, 0038-UTMet= aData-refactoring-static-singleton-accesses-for.patch, 0039-CounterId-remov= ing-static-singleton-accesses-from-st.patch, 0040-AtomicBtreeColumns-replac= ing-SystemKeyspace-CFMetaDa.patch > > > 1st step of CASSANDRA-7837. > Things like DatabaseDescriptor.getPartitioner() should become DatabaseDes= criptor.instance.getPartitioner(). In cases where there is a mix of instanc= e state and static functionality (Keyspace & ColumnFamilyStore classes), th= e static portion should be split off into singleton factory classes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)