Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 07B4811306 for ; Tue, 16 Sep 2014 07:23:35 +0000 (UTC) Received: (qmail 429 invoked by uid 500); 16 Sep 2014 07:23:34 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 398 invoked by uid 500); 16 Sep 2014 07:23:34 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 288 invoked by uid 99); 16 Sep 2014 07:23:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Sep 2014 07:23:34 +0000 Date: Tue, 16 Sep 2014 07:23:34 +0000 (UTC) From: "Benedict (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-7784) DROP table leaves the counter and row cache in a temporarily inconsistent state that, if saved during, will cause an exception to be thrown MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135082#comment-14135082 ] Benedict commented on CASSANDRA-7784: ------------------------------------- Mostly LGTM, in fact it seems like an obvious improvement all round. But I'd either remove the \@Deprecated method entirely, or not deprecate it. Since it's only used in one very cheap to replace place, I'd simply drop it. > DROP table leaves the counter and row cache in a temporarily inconsistent state that, if saved during, will cause an exception to be thrown > ------------------------------------------------------------------------------------------------------------------------------------------- > > Key: CASSANDRA-7784 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7784 > Project: Cassandra > Issue Type: Bug > Reporter: Benedict > Assignee: Aleksey Yeschenko > Priority: Minor > Attachments: 7784.txt > > > It looks like this is quite a realistic race to hit reasonably often, since we forceBlockingFlush after removing from Schema.cfIdMap, so there could be a lengthy window to overlap with an auto-save -- This message was sent by Atlassian JIRA (v6.3.4#6332)