Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Fri, 19 Sep 2014 19:09:34 +0000 (UTC)
From: "Sam Tunnicliffe (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12702932.1395425426000.80188.1411153774525@Atlassian.JIRA>
In-Reply-To: <JIRA.12702932.1395425426000@Atlassian.JIRA>
References: <JIRA.12702932.1395425426000@Atlassian.JIRA>
 <JIRA.12702932.1395425426492@arcas>
Subject: [jira] [Updated] (CASSANDRA-6904) commitlog segments may not be
 archived after restart
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CASSANDRA-6904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sam Tunnicliffe updated CASSANDRA-6904:
---------------------------------------
    Attachment: 2.0-6904.txt
                2.1-6904.txt

Attaching patches for 2.0 & 2.1

If we choose to apply to 2.0 we should note that replaying commit logs isn't safe in the presence of counters (though it's not really made any less safe by this).

For 2.1 I've added an overloaded version of maybeArchive to CLA (actually, it's a resurrection of the pre 2.1 version), which takes a file path & name. This is what gets called at startup as instantiating segments from the unmanaged files in order to archive causes them to be recycled before they're archived. Plus, the version of maybeArchive that takes a CLS waits for it to be synced before performing the archive command, which will never happen for these files.

dtest added in https://github.com/riptano/cassandra-dtest/pull/92

> commitlog segments may not be archived after restart
> ----------------------------------------------------
>
>                 Key: CASSANDRA-6904
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6904
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Sam Tunnicliffe
>             Fix For: 2.0.11, 2.1.1
>
>         Attachments: 2.0-6904.txt, 2.1-6904.txt
>
>
> commitlog segments are archived when they are full, so the current active segment will not be archived on restart (and its contents will not be available for pitr).


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)