Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3C8AF11C2B for ; Wed, 24 Sep 2014 09:08:35 +0000 (UTC) Received: (qmail 74820 invoked by uid 500); 24 Sep 2014 09:08:34 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 74756 invoked by uid 500); 24 Sep 2014 09:08:34 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 74586 invoked by uid 99); 24 Sep 2014 09:08:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Sep 2014 09:08:34 +0000 Date: Wed, 24 Sep 2014 09:08:34 +0000 (UTC) From: =?utf-8?Q?K=C3=A9vin_LOVATO_=28JIRA=29?= To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-6487) Log WARN on large batch sizes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-6487?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 14146103#comment-14146103 ]=20 K=C3=A9vin LOVATO commented on CASSANDRA-6487: ----------------------------------------- We experienced some problems when using (ridiculously) big batches here, Ca= ssandra was throwing odd exceptions: {code} java.lang.IndexOutOfBoundsException: Invalid combined index of 1565817280, = maximum is 482109 at org.jboss.netty.buffer.SlicedChannelBuffer.(SlicedChannelB= uffer.java:46) at org.jboss.netty.buffer.HeapChannelBuffer.slice(HeapChannelBuffer= .java:201) at org.jboss.netty.buffer.AbstractChannelBuffer.readSlice(AbstractC= hannelBuffer.java:323) at org.apache.cassandra.transport.CBUtil.readValue(CBUtil.java:295) at org.apache.cassandra.transport.CBUtil.readValueList(CBUtil.java:= 340) at org.apache.cassandra.transport.messages.BatchMessage$1.decode(Ba= tchMessage.java:62) at org.apache.cassandra.transport.messages.BatchMessage$1.decode(Ba= tchMessage.java:43) at org.apache.cassandra.transport.Message$ProtocolDecoder.decode(Me= ssage.java:212) at org.jboss.netty.handler.codec.oneone.OneToOneDecoder.handleUpstr= eam(OneToOneDecoder.java:66) at org.jboss.netty.handler.codec.oneone.OneToOneDecoder.handleUpstr= eam(OneToOneDecoder.java:68) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.ja= va:296) at org.jboss.netty.handler.codec.frame.FrameDecoder.unfoldAndFireMe= ssageReceived(FrameDecoder.java:462) at org.jboss.netty.handler.codec.frame.FrameDecoder.callDecode(Fram= eDecoder.java:443) at org.jboss.netty.handler.codec.frame.FrameDecoder.messageReceived= (FrameDecoder.java:310) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.ja= va:268) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.ja= va:255) at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java= :88) at org.jboss.netty.channel.socket.nio.AbstractNioWorker.process(Abs= tractNioWorker.java:109) at org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(Abstr= actNioSelector.java:312) at org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(Abstrac= tNioWorker.java:90) at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:= 178) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source= ) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Sourc= e) at java.lang.Thread.run(Unknown Source) {code} We fixed our code so it behaved and stopped sending huge batches, but since= it appears that Cassandra can't handle too big batches, wouldn't it make m= ore sense to simply refuse them instead of warning / crashing ? > Log WARN on large batch sizes > ----------------------------- > > Key: CASSANDRA-6487 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6487 > Project: Cassandra > Issue Type: Improvement > Reporter: Patrick McFadin > Assignee: Lyuben Todorov > Priority: Minor > Fix For: 2.0.8, 2.1 beta2 > > Attachments: 6487-cassandra-2.0.patch, 6487-cassandra-2.0_v2.patc= h > > > Large batches on a coordinator can cause a lot of node stress. I propose = adding a WARN log entry if batch sizes go beyond a configurable size. This = will give more visibility to operators on something that can happen on the = developer side.=20 > New yaml setting with 5k default. > {{# Log WARN on any batch size exceeding this value. 5k by default.}} > {{# Caution should be taken on increasing the size of this threshold as i= t can lead to node instability.}} > {{batch_size_warn_threshold: 5k}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)