cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-7978) CrcCheckChance should not be stored as part of an sstable
Date Mon, 22 Sep 2014 21:52:33 GMT


Jason Brown commented on CASSANDRA-7978:

bq. that is an ephemeral change

d'oh! yes, you are correct.

Then, I'm +1 on the patch. The only nit I would have (and it's rather trivial) is to perhaps
store a reference to an "override" CompressionParameters rather than the whole CFMD (as live
endpoints) in the updated CompressionParameters. 

[~benedict] the reason why FileCacheService.invalidate() wouldn't work is that FCS holds RAR/CRAR
instances, and CRAR gets it's CompressionMetadata from a CompressedPoolingSegmentedFile wrapper
(derived from SegmentedFile), and CPSF what SSTR holds onto for it's lifetime. Thus, CPSF
never gets 'updated' or recycled (via FCS) in the way that CRAR does, so calling FileCacheService.invalidate()
won't do the trick.

> CrcCheckChance should not be stored as part of an sstable
> ---------------------------------------------------------
>                 Key: CASSANDRA-7978
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: sankalp kohli
>            Assignee: T Jake Luciani
>            Priority: Minor
>             Fix For: 2.0.11
>         Attachments: 7978.txt, 7978v2.txt
> CrcCheckChance is stored with compression parameters in the sstable. The only way to
change it is to do upgrade sstable. I don't see why it should not be a hot property. 

This message was sent by Atlassian JIRA

View raw message