cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-7978) CrcCheckChance should not be stored as part of an sstable
Date Tue, 23 Sep 2014 04:44:34 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144324#comment-14144324
] 

Jason Brown edited comment on CASSANDRA-7978 at 9/23/14 4:44 AM:
-----------------------------------------------------------------

I was slightly concerned about the unexpected appearance of the CFMD that's only used in one
place, and hoped we could maybe get around that (as well as reducing the scope of CP's dependencies).
You are correct that we need some wrapper to get those updates, and I just now  spent time
trying to see if it's just easier to pass the CFMD instance into the CP constructor (and always
have a reference to that CFMD, rather than waiting for SSTR.getCompressionMetadata() to pass
it in). Unfortunately, it's not simple as CP has 4 constructors, called from different paths,
and being able to pass the correct CFMD instance to those is not overly friendly. So, I'll
stop making noise now and let you commit the patch so we can move on :).


was (Author: jasobrown):
I was slightly concerned about the unexpected appearance of the CFMD that's only used in one
place, and hoped we could maybe get around that (as well as reducing the scope of CP's dependencies).
You are correct that we need some wrapper to get those updates, and I just now  spent time
trying to see if it's just easier to pass the CFMD instance into the CP constructor (and always
have a reference to that CFMD, rather than waiting for SSTR.getCompressionMetadata()). Unfortunately,
it's not simple as CP has 4 constructors, called from different paths, and being able to pass
the correct CFMD instance to those is not overly friendly. So, I'll stop making noise now
and let you commit the patch so we can move on :).

> CrcCheckChance should not be stored as part of an sstable
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-7978
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7978
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: sankalp kohli
>            Assignee: T Jake Luciani
>            Priority: Minor
>             Fix For: 2.0.11
>
>         Attachments: 7978.txt, 7978v2.txt
>
>
> CrcCheckChance is stored with compression parameters in the sstable. The only way to
change it is to do upgrade sstable. I don't see why it should not be a hot property. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message