cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-7930) Warn when evicting prepared statements from cache
Date Tue, 16 Sep 2014 17:24:34 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135759#comment-14135759
] 

Tyler Hobbs commented on CASSANDRA-7930:
----------------------------------------

Two last minor tweaks and then it should be good to go:
* In the log statement about evicted prepared statements, it should specify that X statements
were discarded _in the last minute_
* Why is {{activePreparedStatements}} incremented in a {{finally}} block?  It should be sufficient
to just increment immediately after the {{put()}} call.

Also, the current code doesn't handle duplicate statements being prepared more than once,
but I'll make sure that gets taken care of in CASSANDRA-7923.

> Warn when evicting prepared statements from cache
> -------------------------------------------------
>
>                 Key: CASSANDRA-7930
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7930
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Robbie Strickland
>            Assignee: Robbie Strickland
>              Labels: bootcamp, jmx
>         Attachments: cassandra-2.0-v2.txt, cassandra-2.0-v3.txt, cassandra-2.0-v4.txt,
cassandra-2.0-v5.txt, cassandra-2.0.txt, cassandra-2.1.txt
>
>
> The prepared statement cache is an LRU, with a max size of maxMemory / 256.  There is
currently no warning when statements are evicted, which could be problematic if the user is
unaware that this is happening.
> At the very least, we should provide a JMX metric and possibly a log message indicating
this is happening.  At some point it may also be worthwhile to make this tunable for users
with large numbers of statements.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message