cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-7818) Improve compaction logging
Date Tue, 16 Sep 2014 14:41:34 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135538#comment-14135538
] 

Benedict edited comment on CASSANDRA-7818 at 9/16/14 2:40 PM:
--------------------------------------------------------------

Is it worth shortening the "SSTableReader()" prefix in the message to clean the messages up
a little further? No need for it really. Something like
{code}
StringBuilder ssTableLoggerMsg = new StringBuilder("[");
for (SSTableReader sstr : sstables)
{
    ssTableLoggerMsg.append(String.format("%s:level %d, ", sstr.getFilename(), sstr.getSSTableLevel()));
}
 ssTableLoggerMsg.append("]");
{code}
?


was (Author: benedict):
Is it worth shortening the "SSTableReader()" prefix in the message to clean the messages up
a little further? No need for it really. Something like
{code}
StringBuilder ssTableLoggerMsg = new StringBuilder("[");
for (SSTableReader sstr : sstables)
{
    ssTableLoggerMsg.append(String.format("%s:level %d), ", sstr.getFilename(), sstr.getSSTableLevel()));
}
 ssTableLoggerMsg.append("]");
{code}
?

> Improve compaction logging
> --------------------------
>
>                 Key: CASSANDRA-7818
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7818
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Mihai Suteu
>            Priority: Minor
>              Labels: compaction, lhf
>             Fix For: 3.0
>
>         Attachments: cassandra-7818.patch
>
>
> We should log more information about compactions to be able to debug issues more efficiently
> * give each CompactionTask an id that we log (so that you can relate the start-compaction-messages
to the finished-compaction ones)
> * log what level the sstables are taken from



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message