cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-4762) Support IN clause for any clustering column
Date Tue, 16 Sep 2014 20:01:35 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136104#comment-14136104
] 

Tyler Hobbs commented on CASSANDRA-4762:
----------------------------------------

Review comments
* {{SelectStatement.buildBound()}}:
 ** In the IN case, we no longer remove duplicates (TreeSet did this automatically)
 ** The single-item and multi-item cases could be combined in the current version (but I guess
not if you add duplicate removal)
* {{CompositesBuilder}}
 ** No curly braces needed for single-line if statements ({{add()}}, {{buildWithEOC()}})
 ** {{add(List<ByteBuffer>)}} is a little deceptive.  I would have guessed that it was
equivalent to calling {{.add(ByteBuffer)}} for each value in the list, but that's not the
case.  Can you come up with a clearer name?
* Add a few more tests:
 ** Tables that use a mixture of ASC/DESC clustering orders (in combination with ordering
clauses)
 ** Duplicate items in the list of IN values
 ** Tests like this one, but with all inequality operators ({{>}}, {{>=}}, {{<}},
{{<=}}): {{select * from %s where a = ? and c >= ? and b in (?, ?)}}


> Support IN clause for any clustering column
> -------------------------------------------
>
>                 Key: CASSANDRA-4762
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4762
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: T Jake Luciani
>            Assignee: Benjamin Lerer
>              Labels: cql, docs
>             Fix For: 3.0
>
>         Attachments: 4762-1.txt
>
>
> Given CASSANDRA-3885
> It seems it should be possible to store multiple ranges for many predicates even the
inner parts of a composite column.
> They could be expressed as a expanded set of filter queries.
> example:
> {code}
> CREATE TABLE test (
>        name text,
>        tdate timestamp,
>        tdate2 timestamp,
>        tdate3 timestamp,
>        num double,
>        PRIMARY KEY(name,tdate,tdate2,tdate3)
>      ) WITH COMPACT STORAGE;
> SELECT * FROM test WHERE 
>   name IN ('a','b') and
>   tdate IN ('2010-01-01','2011-01-01') and
>   tdate2 IN ('2010-01-01','2011-01-01') and
>   tdate3 IN ('2010-01-01','2011-01-01') 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message