cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeremiah Jordan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-7736) Clean-up, justify (and reduce) each use of @Inline
Date Tue, 12 Aug 2014 04:57:12 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093737#comment-14093737
] 

Jeremiah Jordan commented on CASSANDRA-7736:
--------------------------------------------

Was something committed for this already?  I did't see a patch go in.  I think [~jbellis]
just changed the Fix Version because this isn't going to go in 2.1.0?

> Clean-up, justify (and reduce) each use of @Inline
> --------------------------------------------------
>
>                 Key: CASSANDRA-7736
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7736
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: T Jake Luciani
>            Priority: Minor
>             Fix For: 2.1.1
>
>
> \@Inline is a delicate tool, and should in all cases we've used it (and use it in future)
be accompanied by a comment justifying its use in the given context both theoretically and,
preferably, with some brief description of/link to steps taken to demonstrate its benefit.
We should aim to not use it unless we are very confident we can do better than the normal
behaviour, as poor use can result in a polluted instruction cache, which can yield better
results in tight benchmarks, but worse results in general use.
> It looks to me that we have too many uses already. I'll look over each one as well, and
we can compare notes. If there's disagreement on any use, we can discuss, and if still there
is any dissent should always err in favour of *not* using \@Inline.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message