cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Stupp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-7731) Get max values for live/tombstone cells per slice
Date Wed, 13 Aug 2014 07:26:11 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095236#comment-14095236
] 

Robert Stupp commented on CASSANDRA-7731:
-----------------------------------------

I think that calling cfstat does not reset statistics - I'll investigate that when adding
the new max value calls. I tend not add a separate histogram but use the existing instead
and extract the right value - will see what the yammer stuff offers.

For the other stuff I'll add some Javadoc stating that the returned values are just an average
over the last five minutes - I'm not a fan of changing API method names when they are used
"in the wild" :)

> Get max values for live/tombstone cells per slice
> -------------------------------------------------
>
>                 Key: CASSANDRA-7731
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7731
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Cyril Scetbon
>            Assignee: Robert Stupp
>            Priority: Minor
>
> I think you should not say that slice statistics are valid for the [last five minutes
|https://github.com/apache/cassandra/blob/cassandra-2.0/src/java/org/apache/cassandra/tools/NodeCmd.java#L955-L956]
in CFSTATS command of nodetool. I've read the documentation from yammer for Histograms and
there is no way to force values to expire after x minutes except by [clearing|http://grepcode.com/file/repo1.maven.org/maven2/com.yammer.metrics/metrics-core/2.1.2/com/yammer/metrics/core/Histogram.java#96]
it . The only thing I can see is that the last snapshot used to provide the median (or whatever
you'd used instead) value is based on 1028 values.
> I think we should also be able to detect that some requests are accessing a lot of live/tombstone
cells per query and that's not possible for now without activating DEBUG for SliceQueryFilter
for example and by tweaking the threshold. Currently as nodetool cfstats returns the median
if a low part of the queries are scanning a lot of live/tombstone cells we miss it !



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message