cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-7561) On DROP we should invalidate CounterKeyCache as well as Key/Row cache
Date Fri, 15 Aug 2014 17:47:19 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098811#comment-14098811
] 

Benedict edited comment on CASSANDRA-7561 at 8/15/14 5:46 PM:
--------------------------------------------------------------

bq. Well. It shouldn't be throwing any exceptions, AFAIK

CounterCacheKey.getPathInfo() is called during serialization, which is not safe if the CF
has been dropped (since it will get a null cf back). So we still need to address preventing
an autosave happening whilst the map contains keys that are in a dropped CF, or we need getPathInfo()
at least to be safe during this (and return a result that is valid for all use cases), whichever
is easiest.

It looks like this bug may affect the row cache as well, except that we've simply never noticed
it since the window is too small. I filed this ticket a long time ago so cannot remember where/why
I saw this happen. Mea culpa for not filling it into the ticket in the first place.


was (Author: benedict):
bq. Well. It shouldn't be throwing any exceptions, AFAIK

CounterCacheKey.getPathInfo() is called during serialization, which is not safe if the CF
has been dropped (since it will get a null cf back). So we still need to address preventing
an autosave happening whilst the map contains keys that are in a dropped CF, or we need getPathInfo()
at least to be safe during this (and return a result that is valid for all use cases), whichever
is easiest.

> On DROP we should invalidate CounterKeyCache as well as Key/Row cache
> ---------------------------------------------------------------------
>
>                 Key: CASSANDRA-7561
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7561
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Benedict
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 2.1.0
>
>         Attachments: 7561.txt
>
>
> We should also probably ensure we don't attempt to auto save _any_ of the caches while
they are in an inconsistent state (i.e. there are keys present to be saved that should not
be restored, or that would throw exceptions when we save (e.g. CounterCacheKey))



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message