cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Lerer (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-7498) sstable2json exports keys in a wrong format
Date Tue, 05 Aug 2014 10:15:13 GMT


Benjamin Lerer commented on CASSANDRA-7498:

The patch looks good to me.

> sstable2json exports keys in a wrong format
> -------------------------------------------
>                 Key: CASSANDRA-7498
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Alexey Zotov
>            Assignee: Alexey Zotov
>            Priority: Minor
>              Labels: tools
>             Fix For: 2.1.1
>         Attachments: CASSANDRA-2.1-7498.txt
> I examined code of _SSTableImport_ and _SSTableExport_ classes and found one thing that
looks strange to me. Currently processing (encoding/decoding) of columns' names and values
is performed based on CF Comparator and Value Validator correspondingly. But row keys are
processed using _#bytesToHex_ and _#hexToBytes_ methods despite of there is Key Validator.
Such approach works properly for "bytes" keys only. For other types it exports keys in a wrong
format (i.e. they are exported in unreadable form).
> In the scope of this ticket we need to consider backward compatibility (import of previously
exported sstables). For "bytes" keys it will work as previously since _#bytesToHex_ and _#hexToBytes_
methods are used in internals of _BytesType_ class. For other types we need to allow an ability
to import data using "bytes" despite of configured validator.

This message was sent by Atlassian JIRA

View raw message