Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C4E811F4D for ; Tue, 15 Jul 2014 11:34:06 +0000 (UTC) Received: (qmail 20747 invoked by uid 500); 15 Jul 2014 11:34:05 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 20588 invoked by uid 500); 15 Jul 2014 11:34:05 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 20464 invoked by uid 99); 15 Jul 2014 11:34:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Jul 2014 11:34:05 +0000 Date: Tue, 15 Jul 2014 11:34:05 +0000 (UTC) From: "Benedict (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-7232) Enable live replay of commit logs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061965#comment-14061965 ] Benedict commented on CASSANDRA-7232: ------------------------------------- That looks a bit error prone: it should at least take a list of directories. However I'm a little uncomfortable passing node-local paths remotely over nodetool in general, especially when we have very little to help ensure we got it right (we should at least print a list of restored log files when done). In general, I think it would be safer to specify the commit log restore/archive location at startup, but not automatically restore them if specified (have a separate option); then the nodetool command always uses that path, and only accepts a point-in-time option. This is ripe for some bikeshedding, though. [~jbellis] [~thobbs] [~pmcfadin]? > Enable live replay of commit logs > --------------------------------- > > Key: CASSANDRA-7232 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7232 > Project: Cassandra > Issue Type: Improvement > Components: Tools > Reporter: Patrick McFadin > Assignee: Lyuben Todorov > Priority: Minor > Fix For: 2.0.10 > > Attachments: 0001-Expose-CommitLog-recover-to-JMX-add-nodetool-cmd-for.patch, 0001-TRUNK-JMX-and-nodetool-cmd-for-commitlog-replay.patch > > > Replaying commit logs takes a restart but restoring sstables can be an online operation with refresh. In order to restore a point-in-time without a restart, the node needs to live replay the commit logs from JMX and a nodetool command. > nodetool refreshcommitlogs -- This message was sent by Atlassian JIRA (v6.2#6252)