cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-7515) Clean up remains of non-working stack-allocation optimisation
Date Thu, 10 Jul 2014 16:50:05 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14057657#comment-14057657
] 

Benedict commented on CASSANDRA-7515:
-------------------------------------

Patch available [here|https://github.com/belliottsmith/cassandra/tree/7515-cleanup]

> Clean up remains of non-working stack-allocation optimisation
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-7515
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7515
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Aleksey Yeschenko
>            Assignee: Benedict
>            Priority: Trivial
>             Fix For: 2.1.1
>
>
> Can make Allocation fields final (https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogSegment.java#L581-L585)
and get rid of the most likely redundant clone() (https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/Memtable.java#L158-L160)
+ remove the misleading comments.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message