cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vijay (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-7125) Fail to start by default if Commit Log fails to validate any messages
Date Thu, 03 Jul 2014 07:19:25 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051139#comment-14051139
] 

Vijay commented on CASSANDRA-7125:
----------------------------------

Hi [~benedict], is the changes to CommitLogSegment.recycle needed?

Nit: 
CommitLogDescriptor changes is not needed too (as the scoping was right earlier).
CassandraDaemon changes might also be not needed since we print the warn statement and exit
out with a stack trace.


> Fail to start by default if Commit Log fails to validate any messages
> ---------------------------------------------------------------------
>
>                 Key: CASSANDRA-7125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7125
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Minor
>              Labels: correctness
>             Fix For: 2.1.1
>
>
> Current behaviour can be pretty dangerous, and also has a tendency to mask bugs during
development. We should change the behaviour to default to failure if anything unexpected happens,
and introduce a cassandra.yaml option that permits overriding the default behaviour.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message