cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-7111) Include snippet of CQL query near error in SyntaxError messages
Date Tue, 15 Jul 2014 17:19:05 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062344#comment-14062344
] 

Tyler Hobbs commented on CASSANDRA-7111:
----------------------------------------

Thanks, committed to cassandra-2.1 and trunk.

However, I noticed that a couple of the new unit tests are failing in trunk:

{noformat}
    [junit] Testsuite: org.apache.cassandra.cql3.CqlParserTest
    [junit] Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.161 sec
    [junit] 
    [junit] Testcase: testRemoveErrorListener(org.apache.cassandra.cql3.CqlParserTest):	FAILED
    [junit] expected:<1> but was:<2>
    [junit] junit.framework.AssertionFailedError: expected:<1> but was:<2>
    [junit] 	at org.apache.cassandra.cql3.CqlParserTest.testRemoveErrorListener(CqlParserTest.java:70)
    [junit] 
    [junit] 
    [junit] Testcase: testAddErrorListener(org.apache.cassandra.cql3.CqlParserTest):	FAILED
    [junit] expected:<1> but was:<2>
    [junit] junit.framework.AssertionFailedError: expected:<1> but was:<2>
    [junit] 	at org.apache.cassandra.cql3.CqlParserTest.testAddErrorListener(CqlParserTest.java:49)
    [junit] 
    [junit] 
    [junit] Test org.apache.cassandra.cql3.CqlParserTest FAILED
{noformat}

Can you post a second patch to fix the tests on trunk?

> Include snippet of CQL query near error in SyntaxError messages
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-7111
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7111
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: API, Tools
>            Reporter: Tyler Hobbs
>            Assignee: Benjamin Lerer
>              Labels: cql
>             Fix For: 2.1.1
>
>         Attachments: CASSANDRA-7111-V2.txt, CASSANDRA-7111-V3.txt, CASSANDRA-7111.txt
>
>
> When a SyntaxError is returned, including a snippet of the query close to the error would
make a lot of error messages easier to understand.  For example, if you did this with the
python driver:
> {code}
> session.execute(SELECT * FROM users WHERE username='%s', ['Joe Smith'])
> {code}
> you would wind up with an extra set of single quotes (the driver automatically escapes
and quotes input).  If a snippet like {{...WHERE username=''Joe Smith''}} were included in
the error message, this would be pretty easy to spot.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message