Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Sat, 14 Jun 2014 13:07:01 +0000 (UTC)
From: "Lyuben Todorov (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12721216.1402703005107.132137.1402751221833@arcas>
In-Reply-To: <JIRA.12721216.1402703005107@arcas>
References: <JIRA.12721216.1402703005107@arcas>
Subject: [jira] [Commented] (CASSANDRA-7398) Using the -Dcassandra.config VM
 param needs a "file:///" prefix for the supplied URL
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CASSANDRA-7398?page=3Dcom.atlas=
sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D=
14031566#comment-14031566 ]=20

Lyuben Todorov commented on CASSANDRA-7398:
-------------------------------------------

Recovering in this case could mislead the user into thinking they supplied =
a valid url when that was not the case, and can lead to confusion if the ur=
l is processed elsewhere, but I agree that we should handle the failure by =
warning the user.=20

Nits on the patch:
# remove the curly brackets from the single line if statement
# Can we change the warning to something like {{logger.warn(message + ". Re=
-attempting to use config file " + configUrl);}} and also explain why this =
is happening with a warn.
# //Try one more time isn't very verbose, we should state why another attem=
pt is being made.

> Using the -Dcassandra.config VM param needs a "file:///" prefix for the s=
upplied URL
> -------------------------------------------------------------------------=
-----------
>
>                 Key: CASSANDRA-7398
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7398
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>         Environment:  Cassandra 2.1.0-rc1-SNAPSHOT, Win 7
>            Reporter: Marco Tulio Avila Cer=C3=B3n
>            Priority: Minor
>              Labels: lhf, patch
>             Fix For: 2.1 rc1
>
>         Attachments: CASSANDRA-7398_prefix.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The parameter in the VM options -Dcassandra.config=3D needs file:///
> Allow the user to have optional "file:///" when loading the config file f=
rom the filesystem


--
This message was sent by Atlassian JIRA
(v6.2#6252)