Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3DC2D111C3 for ; Tue, 24 Jun 2014 01:03:13 +0000 (UTC) Received: (qmail 50757 invoked by uid 500); 24 Jun 2014 01:03:13 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 50714 invoked by uid 500); 24 Jun 2014 01:03:13 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 50701 invoked by uid 99); 24 Jun 2014 01:03:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jun 2014 01:03:13 +0000 Date: Tue, 24 Jun 2014 01:03:12 +0000 (UTC) From: "Aleksey Yeschenko (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-7394) Fix CollationController#collectTimeOrderedData() mostRecentRowTombstone tracking MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-7394: ----------------------------------------- Attachment: 7394.txt > Fix CollationController#collectTimeOrderedData() mostRecentRowTombstone tracking > -------------------------------------------------------------------------------- > > Key: CASSANDRA-7394 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7394 > Project: Cassandra > Issue Type: Bug > Reporter: Aleksey Yeschenko > Assignee: Aleksey Yeschenko > Priority: Minor > Fix For: 2.0.9, 2.1.0 > > Attachments: 7394.txt > > > As of now, collectTimeOrderedData() will try to read from at least one sstable, even if the memtable has a row tombstone with a higher timestamp than any max timestamp in the sstable. If we initiate mostRecentRowTombstone with the value from the memtables and not Long.MIN_VALUE, reading from the sstables can be avoided entirely in this scenario. > Current tracking is also broken b/c we update mostRecentRowTombstone value with the one read from the last sstable, unconditionally, even if it's a lesser tombstone than we used to have tracked. -- This message was sent by Atlassian JIRA (v6.2#6252)