cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lyuben Todorov (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-7398) Using the -Dcassandra.config VM param needs a "file:///" prefix for the supplied URL
Date Sat, 14 Jun 2014 13:07:01 GMT


Lyuben Todorov commented on CASSANDRA-7398:

Recovering in this case could mislead the user into thinking they supplied a valid url when
that was not the case, and can lead to confusion if the url is processed elsewhere, but I
agree that we should handle the failure by warning the user. 

Nits on the patch:
# remove the curly brackets from the single line if statement
# Can we change the warning to something like {{logger.warn(message + ". Re-attempting to
use config file " + configUrl);}} and also explain why this is happening with a warn.
# //Try one more time isn't very verbose, we should state why another attempt is being made.

> Using the -Dcassandra.config VM param needs a "file:///" prefix for the supplied URL
> ------------------------------------------------------------------------------------
>                 Key: CASSANDRA-7398
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>         Environment:  Cassandra 2.1.0-rc1-SNAPSHOT, Win 7
>            Reporter: Marco Tulio Avila CerĂ³n
>            Priority: Minor
>              Labels: lhf, patch
>             Fix For: 2.1 rc1
>         Attachments: CASSANDRA-7398_prefix.patch
>   Original Estimate: 2h
>  Remaining Estimate: 2h
> The parameter in the VM options -Dcassandra.config= needs file:///
> Allow the user to have optional "file:///" when loading the config file from the filesystem

This message was sent by Atlassian JIRA

View raw message