cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-7346) Modify reconcile logic to always pick a tombstone over a counter cell
Date Thu, 19 Jun 2014 13:45:25 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037334#comment-14037334
] 

Sylvain Lebresne commented on CASSANDRA-7346:
---------------------------------------------

Lgtm, +1.

One small nit: I'd put some isLive() in DeletionTime and replace the {{topLevel.markedForDeleteAt
> Long.MIN_VALUE}} by {{!topLevel.isLive()}}. Feels more explicit/readable.

> Modify reconcile logic to always pick a tombstone over a counter cell
> ---------------------------------------------------------------------
>
>                 Key: CASSANDRA-7346
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7346
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Richard Low
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 2.1 rc2
>
>
> For counters, timestamps are automatically computed to be milliseconds since the epoch.
For everything else, when not specified manually, they are microseconds since the epoch. This
means if you delete a counter row, subsequent updates are lost unexpectedly.
> I know that deleting counters is not recommended, but that's only because deletes and
incs don't commute. If you know you have stopped incs, then delete, then start again (with
some external synchronization) then deleting is fine.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message