cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua McKenzie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-7327) Reduce new CQL test time
Date Wed, 04 Jun 2014 15:45:03 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017784#comment-14017784
] 

Joshua McKenzie commented on CASSANDRA-7327:
--------------------------------------------

Dangerous is relative; so long as we behave ourselves w/releasing resources before deletion
it works like a charm.  ;)

Testing all 4 patches vs. trunk, looks like we have 1 extra unit-test failure:
{code:title=failure_details}
    [junit] Testcase: testSingleClustering(org.apache.cassandra.cql3.MultiColumnRelationTest):
 Caused an ERROR
    [junit] Error setting schema for test (query was: CREATE TABLE cql_test_keyspace.table_1
(a int, b int, c int, PRIMARY KEY (a, b)))
    [junit] java.lang.RuntimeException: Error setting schema for test (query was: CREATE TABLE
cql_test_keyspace.table_1 (a int, b int,
    [junit]     at org.apache.cassandra.cql3.CQLTester.schemaChange(CQLTester.java:145)
    [junit]     at org.apache.cassandra.cql3.CQLTester.createTable(CQLTester.java:133)
    [junit]     at org.apache.cassandra.cql3.MultiColumnRelationTest.testSingleClustering(MultiColumnRelationTest.java:87)
    [junit] Caused by: java.lang.IllegalArgumentException: Unknown keyspace/cf pair (cql_test_keyspace.table_0)
    [junit]     at org.apache.cassandra.db.Keyspace.getColumnFamilyStore(Keyspace.java:178)
    [junit]     at org.apache.cassandra.db.DefsTables.dropColumnFamily(DefsTables.java:504)
    [junit]     at org.apache.cassandra.db.DefsTables.mergeColumnFamilies(DefsTables.java:318)
    [junit]     at org.apache.cassandra.db.DefsTables.mergeSchemaInternal(DefsTables.java:187)
    [junit]     at org.apache.cassandra.service.MigrationManager.announce(MigrationManager.java:365)
    [junit]     at org.apache.cassandra.service.MigrationManager.announceNewColumnFamily(MigrationManager.java:249)
    [junit]     at org.apache.cassandra.cql3.statements.CreateTableStatement.announceMigration(CreateTableStatement.java:112)
    [junit]     at org.apache.cassandra.cql3.statements.SchemaAlteringStatement.executeInternal(SchemaAlteringStatement.java:80)
    [junit]     at org.apache.cassandra.cql3.QueryProcessor.executeOnceInternal(QueryProcessor.java:306)
    [junit]     at org.apache.cassandra.cql3.CQLTester.schemaChange(CQLTester.java:141)
    [junit]
    [junit]
    [junit] Test org.apache.cassandra.cql3.MultiColumnRelationTest FAILED
{code}

I haven't dug into it deeply but at face value it doesn't look like it's due to any FSWriteError
or deletion problems from patch 4.

> Reduce new CQL test time
> ------------------------
>
>                 Key: CASSANDRA-7327
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7327
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 2.1.0
>
>         Attachments: 0001-Don-t-require-Gossiper-for-schema-changes.txt, 0002-Don-t-flush-schema-tables-all-the-time.txt,
0003-Reduce-memtable-static-initialization-time-for-tests.txt, 0004-Use-forkmode-once-for-cql-test.txt
>
>
> We've introduced CQL tests in the unit test suite and in particular a new CQLTester class
meant for all those test to use. Currently, we have only 2 test classes yet those tests takes
about 20-22 seconds to run on my box. This is way too long.
> This issue is linked to CASSANDRA-6968, but here I'm only focusing on the CQL tests.
Those don't load all the schema from SchemaLoader so are not directly targeted by CASSANDRA-6968.
That said, I think most of what is done here can be backported to the rest of the unit tests
and I'll let that to CASSANDRA-6968.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message