Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 667F510110 for ; Fri, 23 May 2014 01:02:42 +0000 (UTC) Received: (qmail 47767 invoked by uid 500); 23 May 2014 01:02:42 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 47732 invoked by uid 500); 23 May 2014 01:02:42 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 47723 invoked by uid 99); 23 May 2014 01:02:42 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 May 2014 01:02:42 +0000 Date: Fri, 23 May 2014 01:02:42 +0000 (UTC) From: "Edward Capriolo (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-7279) MultiSliceTest.test_with_overlap* unit tests failing in trunk MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-7279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006668#comment-14006668 ] Edward Capriolo commented on CASSANDRA-7279: -------------------------------------------- I linked two issues I opened up months ago which are also this issue. {quote} changing ABSC.maybeAppendColumn to use addColumn vs addInternal (so it checks the previous value) {quote} Not to be critical, but I think ABSC is hard to groc. As an nube without context it is very hard to me understand what it's purpose is and how it is supposed to behave without more Java doc and direct testing. For a speciality data structure the intent is lost without more documentation. Suggestion: maybe we can beef up the javadoc in the patch? > MultiSliceTest.test_with_overlap* unit tests failing in trunk > ------------------------------------------------------------- > > Key: CASSANDRA-7279 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7279 > Project: Cassandra > Issue Type: Bug > Components: Tests > Reporter: Michael Shuler > Assignee: T Jake Luciani > Priority: Minor > Fix For: 2.1 rc1 > > Attachments: 7279-trunk.txt > > > Example: > https://cassci.datastax.com/job/trunk_utest/623/testReport/org.apache.cassandra.thrift/MultiSliceTest/ -- This message was sent by Atlassian JIRA (v6.2#6252)