cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward Capriolo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-7279) MultiSliceTest.test_with_overlap* unit tests failing in trunk
Date Fri, 23 May 2014 00:44:01 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006657#comment-14006657
] 

Edward Capriolo commented on CASSANDRA-7279:
--------------------------------------------

Were you just testing this? All the Slices are in one direction but the order should not matter.

{code}
-        req.setColumn_slices(Arrays.asList(columnSliceFrom("e", "a"), columnSliceFrom("g",
"d")));
+        req.setColumn_slices(Arrays.asList( columnSliceFrom("g", "d"), columnSliceFrom("e",
"a")));
{code}

Good call. This assert was backwards
{code}
     private static void assertColumnNameMatches(List<String> expected , List<ColumnOrSuperColumn>
actual)
     {
-        Assert.assertEquals(actual+" "+expected +" did not have same number of elements",
actual.size(), expected.size());
+        Assert.assertEquals(actual+" "+expected +" did not have same number of elements",
expected.size(), actual.size());
         for (int i = 0 ; i< expected.size() ; i++)
         {
-            Assert.assertEquals(actual.get(i) +" did not equal "+ expected.get(i), 
-                    new String(actual.get(i).getColumn().getName()), expected.get(i));
+            Assert.assertEquals(actual.get(i) +" did not equal "+ expected.get(i), expected.get(i),
+                    new String(actual.get(i).getColumn().getName()));
         }
     }
{code}

> MultiSliceTest.test_with_overlap* unit tests failing in trunk
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-7279
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7279
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Michael Shuler
>            Assignee: T Jake Luciani
>            Priority: Minor
>             Fix For: 2.1 rc1
>
>         Attachments: 7279-trunk.txt
>
>
> Example:
> https://cassci.datastax.com/job/trunk_utest/623/testReport/org.apache.cassandra.thrift/MultiSliceTest/



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message