cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Shuler (JIRA)" <>
Subject [jira] [Updated] (CASSANDRA-7160) clean up tools/bin
Date Sat, 24 May 2014 03:57:01 GMT


Michael Shuler updated CASSANDRA-7160:

    Attachment: 7160.txt

Patch for cassandra attached. I assumed that cassandra-stress should remain in the cassandra
debian package and not be moved to the cassandra-tools deb. [~brandon.williams] let me know
if my assumption was incorrect.

Still ToDo:
- patch ccm for version >= 2.1 to get path changes to tools/bin/...
(we should probably commit to c* and ccm pretty closely, so tests don't go haywire too much)

(master)mshuler@hana:~/git/ccm$ for i in json2sstable sstable2json sstablesplit; do echo ==
$i ==; grep -r $i .; done
== json2sstable ==
== sstable2json ==
./ccmlib/cmds/        return "Call sstable2json on the sstables of this node"
./ccmlib/cmds/            self.node.run_sstable2json(self.keyspace, self.datafile,
self.column_families, self.options.enumerate_keys)
./ccmlib/    def run_sstable2json(self, keyspace=None, datafile=None, column_families=None,
./ccmlib/        sstable2json = common.join_bin(cdir, 'bin', 'sstable2json')
./ccmlib/            args = [ sstable2json , file ]
== sstablesplit ==
./ccmlib/cmds/        "sstablesplit",
./ccmlib/cmds/        return "Run sstablesplit on the sstables of this node"
./ccmlib/cmds/        usage = "usage: ccm node_name sstablesplit [options] [file]"
./ccmlib/cmds/            self.node.run_sstablesplit(datafile=self.datafile,
./ccmlib/cmds/            self.node.run_sstablesplit(keyspace=self.keyspace,
column_families=self.column_families, size=self.size)
./ccmlib/    def run_sstablesplit(self, datafile=None,  size=None, keyspace=None,
./ccmlib/        sstablesplit = common.join_bin(cdir, 'bin', 'sstablesplit')
./ccmlib/       [sstablesplit, '-s', str(size), f], cwd=os.path.join(cdir,
'bin'), env=env )
./ccmlib/       [sstablesplit, f], cwd=os.path.join(cdir,
'bin'), env=env )
./README:    - non nodetool-based command-line options fail (sstablesplit, scrub, etc)

(a search through dtest did not reveal any direct calls to any of the moved scripts)

> clean up tools/bin
> ------------------
>                 Key: CASSANDRA-7160
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Packaging
>            Reporter: Brandon Williams
>            Assignee: Michael Shuler
>            Priority: Minor
>             Fix For: 2.1 rc1
>         Attachments: 7160.txt
> Right now we have most utils in bin/, but sstablemetadata is an outlier in tools/bin.
 For packaging, we don't care what the source directory is, we put everything in /usr/bin.
 We want to keep some things out of users' hands unless they know what they're doing (like
sstable2json) so I propose that we break these things out into a companion cassandra-tools
package that will depend on cassandra.

This message was sent by Atlassian JIRA

View raw message