cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-7107) General minor tidying of CollationController path
Date Mon, 05 May 2014 19:41:20 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989890#comment-13989890
] 

Benedict commented on CASSANDRA-7107:
-------------------------------------

LGTM. I don't think there's any off-by-1 error, unless I'm missing something: do you have
a specific case you think may be off?

> General minor tidying of CollationController path
> -------------------------------------------------
>
>                 Key: CASSANDRA-7107
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7107
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Minor
>             Fix For: 2.1 rc1
>
>
> There is a lot of unnecessary boiler plate when grabbing an iterator from an in-memory
column family. This patch:
> * Removes FakeCellName
> * Avoids wrapping a non-OnDiskAtomIterator as an OnDiskAtomIterator except when the wrapping
is useful
> * Removes ColumnSlice.NavigableSetIterator and creates a simpler more direct equivalent
in ABTC
> * Does not construct a SliceIterator in either ABSC or ABTC if only one slice is requested
(just returns that slice as an Iterator)
> * Does not construct multiple list indirections in ABSC when constructing a slice
> * Shares forward/reverse iterators in ABSC between slices and full-iteration
> * Avoids O(N) comparisons during collation of results into an ABSC, by using the knowledge
that all columns are provided in insertion order from a merge iterator



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message