cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6861) Optimise our Netty 4 integration
Date Wed, 07 May 2014 00:16:22 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13991387#comment-13991387
] 

Benedict commented on CASSANDRA-6861:
-------------------------------------

Nits:

* frame.release() in the compressors should go in a finally block
* would prefer to catch (Throwable t) and use Java 7's (re)throw where possible, instead of
always wrapping in IOException
* in the LZ4 compressor, would prefer to grab the array and arrayOffset once only, and refer
to them from local variables, as each is a virtual method invocation so is unlikely to be
inlined by the VM.

Otherwise LGTM

> Optimise our Netty 4 integration
> --------------------------------
>
>                 Key: CASSANDRA-6861
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6861
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: T Jake Luciani
>            Priority: Minor
>              Labels: performance
>             Fix For: 2.1 rc1
>
>
> Now we've upgraded to Netty 4, we're generating a lot of garbage that could be avoided,
so we should probably stop that. Should be reasonably easy to hook into Netty's pooled buffers,
returning them to the pool once a given message is completed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message