cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "T Jake Luciani (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-6861) Optimise our Netty 4 integration
Date Tue, 06 May 2014 15:15:33 GMT


T Jake Luciani commented on CASSANDRA-6861:

bq. 1) It would be nice, since we effectively create a static allocator, to reference it from
a static context instead of grabbing it from the buffer we've been passed by Netty

Done on v2 branch

bq. 2)  I'm a little concerned we aren't tidying up in the case of exceptions.

I'm not sure I follow you.  The encoder would be the main place an exception would be encountered
but the dispatcher has a finally that frees the resources so I don't see how we can leak (unless
calling write and flush doesn't do what I think it does).

> Optimise our Netty 4 integration
> --------------------------------
>                 Key: CASSANDRA-6861
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: T Jake Luciani
>            Priority: Minor
>              Labels: performance
>             Fix For: 2.1 rc1
> Now we've upgraded to Netty 4, we're generating a lot of garbage that could be avoided,
so we should probably stop that. Should be reasonably easy to hook into Netty's pooled buffers,
returning them to the pool once a given message is completed.

This message was sent by Atlassian JIRA

View raw message