Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Mon, 14 Apr 2014 23:49:14 +0000 (UTC)
From: "Joshua McKenzie (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12708106.1397335866691.114310.1397519354873@arcas>
In-Reply-To: <JIRA.12708106.1397335866691@arcas>
References: <JIRA.12708106.1397335866691@arcas>
Subject: [jira] [Commented] (CASSANDRA-7028) Allow C* to compile under java
 8
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-7028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969015#comment-13969015 ] 

Joshua McKenzie commented on CASSANDRA-7028:
--------------------------------------------

Tests pass, looks good.  +1 from me though I do have 1 question:

What's our reasoning as to what libraries we store in {basedir}/lib and what libraries we expect to pull using ant into build/lib/*?  antlr was previously housed in {basedir}/lib and it looks like you put the antlr runtime and stringtemplate into that folder, however the antlr full is pulled into build/lib.  Any insight into the reasoning there?

> Allow C* to compile under java 8
> --------------------------------
>
>                 Key: CASSANDRA-7028
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7028
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: 7028.txt, 7028_v2.txt, 7028_v3.txt
>
>
> antlr 3.2 has a problem with java 8, as described here: http://bugs.java.com/bugdatabase/view_bug.do?bug_id=8015656
> updating to antlr 3.5.2 solves this, however they have split up the jars differently, which adds some changes, but also the generation of CqlParser.java causes a method to be too large, so i needed to split that method to reduce the size of it.
> (patch against trunk)


--
This message was sent by Atlassian JIRA
(v6.2#6252)