Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C731E10DFD for ; Sat, 5 Apr 2014 01:34:16 +0000 (UTC) Received: (qmail 5014 invoked by uid 500); 5 Apr 2014 01:34:15 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 4951 invoked by uid 500); 5 Apr 2014 01:34:15 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 4941 invoked by uid 99); 5 Apr 2014 01:34:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Apr 2014 01:34:15 +0000 Date: Sat, 5 Apr 2014 01:34:15 +0000 (UTC) From: "Brandon Williams (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-6984) NullPointerException in Streaming During Repair MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-6984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960893#comment-13960893 ] Brandon Williams commented on CASSANDRA-6984: --------------------------------------------- Not really, it's a streaming problem. > NullPointerException in Streaming During Repair > ----------------------------------------------- > > Key: CASSANDRA-6984 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6984 > Project: Cassandra > Issue Type: Bug > Components: Core > Reporter: Tyler Hobbs > Assignee: Yuki Morishita > Priority: Blocker > Fix For: 2.0.7 > > > In cassandra-2.0, I can trigger a NullPointerException with a repair. These steps should reproduce the issue: > * create a three node ccm cluster (with vnodes) > * start a stress write (I'm using {{tools/bin/cassandra-stress --replication-factor=3 -n 10000000 -k -t 1}}) > * stop node3 while stress is running, then wait a minute > * start node 3 > * run "ccm node3 repair" > In the logs for node1, I see this: > {noformat} > ERROR [STREAM-OUT-/127.0.0.3] 2014-04-04 17:40:08,547 CassandraDaemon.java (line 198) Exception in thread Thread[STREAM-OUT-/127.0.0.3,5,main] > java.lang.NullPointerException > at org.apache.cassandra.streaming.ConnectionHandler$MessageHandler.signalCloseDone(ConnectionHandler.java:249) > at org.apache.cassandra.streaming.ConnectionHandler$OutgoingMessageHandler.run(ConnectionHandler.java:375) > at java.lang.Thread.run(Thread.java:724) > {noformat} > After applying Yuki's suggested patch: > {noformat} > diff --git a/src/java/org/apache/cassandra/streaming/ConnectionHandler.java b/src/java/org/apache/cassandra/streaming/ConnectionHandler.java > index 356138b..b06a818 100644 > --- a/src/java/org/apache/cassandra/streaming/ConnectionHandler.java > +++ b/src/java/org/apache/cassandra/streaming/ConnectionHandler.java > @@ -366,7 +366,7 @@ public class ConnectionHandler > { > throw new AssertionError(e); > } > - catch (IOException e) > + catch (Throwable e) > { > session.onError(e); > } > {noformat} > I see a new NPE: > {noformat} > ERROR [STREAM-OUT-/127.0.0.3] 2014-04-04 18:12:35,912 StreamSession.java (line 420) [Stream #9b592af0-bc4e-11e3-a6f9-43eb3a328df9] Streaming error occurred > java.lang.NullPointerException > at org.apache.cassandra.streaming.StreamSession.fileSent(StreamSession.java:465) > at org.apache.cassandra.streaming.messages.OutgoingFileMessage$1.serialize(OutgoingFileMessage.java:60) > at org.apache.cassandra.streaming.messages.OutgoingFileMessage$1.serialize(OutgoingFileMessage.java:42) > at org.apache.cassandra.streaming.messages.StreamMessage.serialize(StreamMessage.java:45) > at org.apache.cassandra.streaming.ConnectionHandler$OutgoingMessageHandler.sendMessage(ConnectionHandler.java:383) > at org.apache.cassandra.streaming.ConnectionHandler$OutgoingMessageHandler.run(ConnectionHandler.java:355) > at java.lang.Thread.run(Thread.java:724) > {noformat} -- This message was sent by Atlassian JIRA (v6.2#6252)