Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Fri, 4 Apr 2014 21:27:25 +0000 (UTC)
From: "Brandon Williams (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12706712.1396646781429.66727.1396646845583@arcas>
In-Reply-To: <JIRA.12706712.1396646781429@arcas>
References: <JIRA.12706712.1396646781429@arcas>
Subject: [jira] [Created] (CASSANDRA-6983) DirectoriesTest fails when run as
 root
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Brandon Williams created CASSANDRA-6983:
-------------------------------------------

             Summary: DirectoriesTest fails when run as root
                 Key: CASSANDRA-6983
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6983
             Project: Cassandra
          Issue Type: Bug
          Components: Tests
            Reporter: Brandon Williams
            Assignee: Yuki Morishita
             Fix For: 2.0.7


When you run the DirectoriesTest as a normal user, it passes because it fails to create the 'bad' directory:

{noformat}
    [junit] ------------- Standard Error -----------------
    [junit] ERROR 16:16:18,111 Failed to create /tmp/cassandra4119802552776680052unittest/ks/bad directory
    [junit]  WARN 16:16:18,112 Blacklisting /tmp/cassandra4119802552776680052unittest/ks/bad for writes
    [junit] ------------- ---------------- ---------------
{noformat}

But when you run the test as root, it succeeds in making the directory, causing an assertion failure that it's unwritable:

{noformat}
    [junit] Testcase: testDiskFailurePolicy_best_effort(org.apache.cassandra.db.DirectoriesTest):       FAILED
    [junit] 
    [junit] junit.framework.AssertionFailedError: 
    [junit]     at org.apache.cassandra.db.DirectoriesTest.testDiskFailurePolicy_best_effort(DirectoriesTest.java:199)
{noformat}

It seems to me that we shouldn't be relying on failing the make the directory.  If we're just going to test a nonexistent dir, why try to make one at all?  And if that is supposed to succeed, then we have a problem with either the test or blacklisting.


--
This message was sent by Atlassian JIRA
(v6.2#6252)