cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-7047) TriggerExecutor should group mutations by row key
Date Fri, 18 Apr 2014 21:54:19 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974531#comment-13974531
] 

Aleksey Yeschenko commented on CASSANDRA-7047:
----------------------------------------------

Actually, there are also two bugs in the original patch:
- cowRm.addAll(updateRm) would throw if updateRm is a CounterMutation
- TriggerExecutor#execute() should keep accepting Collection<? extends IMutation>, since
there can be CounterMutation-s

That, and it wasn't grouping the mutations in all possible cases. So wouldn't group in a scenario
where a trigger on mutation M1 would create a bunch of mutations for the same key/keyspace
as some mutation M2 afterwards.

Attaching a v3 addressing all these - please have a look.

> TriggerExecutor should group mutations by row key
> -------------------------------------------------
>
>                 Key: CASSANDRA-7047
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7047
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Sergio Bossa
>            Assignee: Sergio Bossa
>         Attachments: 7047-v2.txt, 7047-v3.txt, CASSANDRA-7047.patch
>
>
> TriggerExecutor doesn't currently group mutations returned by triggers even if belonging
to the same row key: while harmful per se (at least, I think so), this is definitely a performance
problem, because each mutation is a *cluster* mutation, generating more network traffic, more
disk IO and more index calls (if present).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message