cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua McKenzie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-7028) Allow C* to compile under java 8
Date Mon, 14 Apr 2014 20:42:15 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968812#comment-13968812
] 

Joshua McKenzie commented on CASSANDRA-7028:
--------------------------------------------

            There were a few things I ironed out: created patch with --full-index, moved the
build.lib/* references to build.dir.lib/jars as this patch didn't have a binary add of the
\{basedir\}/lib/*.jar changes, changed from stringtemplate to ST4 as antlr 3.5.2 wouldn't
build without it, though the pom for it looks like it references both ST4 and stringtemplate
in retrospect... hm.

            Attaching updated patch.  All that being said - this patch looks like it breaks
HintedHandoff when tested against jdk 7 on linux:

{code:title=HintedHandOffTest}
    [junit] Error validating UPDATE system.peer_events USING TTL 2592000 SET hints_dropped[
b666cce0-c413-11e3-b7c0-0f1b1496192d ] = 99 WHERE peer = '192.168.1.51'
    [junit] java.lang.RuntimeException: Error validating UPDATE system.peer_events USING TTL
2592000 SET hints_dropped[ b666cce0-c413-11e3-b7c0-0f1b1496192d ] = 99 WHERE peer = '192.168.1.51'
    [junit]     at org.apache.cassandra.cql3.QueryProcessor.processInternal(QueryProcessor.java:211)
    [junit]     at org.apache.cassandra.db.SystemKeyspace.updateHintsDropped(SystemKeyspace.java:406)
    [junit]     at org.apache.cassandra.metrics.HintedHandoffMetrics.log(HintedHandoffMetrics.java:80)
    [junit]     at org.apache.cassandra.db.HintedHandOffTest.testHintsMetrics(HintedHandOffTest.java:90)
    [junit] Caused by: org.apache.cassandra.exceptions.SyntaxException: line 1:102 mismatched
input '=' expecting K_WHERE
    [junit]     at org.apache.cassandra.cql3.CqlParser.throwLastRecognitionError(CqlParser.java:281)
    [junit]     at org.apache.cassandra.cql3.QueryProcessor.parseStatement(QueryProcessor.java:349)
    [junit]     at org.apache.cassandra.cql3.QueryProcessor.getStatement(QueryProcessor.java:323)
    [junit]     at org.apache.cassandra.cql3.QueryProcessor.processInternal(QueryProcessor.java:197)
    [junit]
    [junit]
    [junit] Test org.apache.cassandra.db.HintedHandOffTest FAILED
{code}

So I'm a -1 until we can get that figured out.  May very well be due to ST4 ant / maven package
changes, so I'll take a look.  Also - we'll need to go for a v3 at least if we go ST4 as I
forgot to update license from 4.0.2 to 4.0.8.

> Allow C* to compile under java 8
> --------------------------------
>
>                 Key: CASSANDRA-7028
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7028
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: 7028.txt, 7028_v2.txt
>
>
> antlr 3.2 has a problem with java 8, as described here: http://bugs.java.com/bugdatabase/view_bug.do?bug_id=8015656
> updating to antlr 3.5.2 solves this, however they have split up the jars differently,
which adds some changes, but also the generation of CqlParser.java causes a method to be too
large, so i needed to split that method to reduce the size of it.
> (patch against trunk)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message