cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6999) Batchlog replay should account for CF truncation records
Date Thu, 17 Apr 2014 21:45:23 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973456#comment-13973456
] 

Aleksey Yeschenko commented on CASSANDRA-6999:
----------------------------------------------

bq. Looks to me like the ImmutableSet copy in replayBatch is unnecessary, since mutation.without
creates a new modifications map rather than modifying the original.

It is necessary :( http://docs.oracle.com/javase/7/docs/api/java/util/Map.html#keySet() -
if not copied, might return a ConcurrentModificationException.

bq. Who wins on ties? Should writtenAt < SystemTable.getTruncatedAt be <=?

Probably. Will alter HHOM to use <= as well.

> Batchlog replay should account for CF truncation records
> --------------------------------------------------------
>
>                 Key: CASSANDRA-6999
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6999
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Aleksey Yeschenko
>            Assignee: Aleksey Yeschenko
>             Fix For: 1.2.17, 2.0.8, 2.1 beta2
>
>
> Just as HHOM does, BM should properly handle column families' truncation records and
not replay mutations that are younger that the last known record.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message