cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuki Morishita (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6985) ReadExecutors should not rely on static StorageProxy
Date Tue, 15 Apr 2014 17:43:27 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969798#comment-13969798
] 

Yuki Morishita commented on CASSANDRA-6985:
-------------------------------------------

Ed,

I don't see the reason to pass StorageProxy to AbstractReadExecutor at all.
It is only used to get live sorted endpoints from it in getExecutor so why just pass List<InetAddress>?

I see the only reason that StorageProxy singleton instance exists right now is mainly for
JMX.
Is it more reasonable (for now?) to leave StorageProxy as an utility class/API and separate
its managing aspect to another class?


> ReadExecutors should not rely on static StorageProxy
> ----------------------------------------------------
>
>                 Key: CASSANDRA-6985
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6985
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: CASSANDRA_6985.1.patch
>
>
> All the Read Executor child classes require use of the Storage Proxy to carry out read.
We can pass the StorageProxy along in the constructor.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message