cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward Capriolo (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-6985) ReadExecutors should not rely on static StorageProxy
Date Sun, 13 Apr 2014 23:26:14 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967981#comment-13967981
] 

Edward Capriolo edited comment on CASSANDRA-6985 at 4/13/14 11:24 PM:
----------------------------------------------------------------------

[~iamaleksey] See my comment at the end of CASSANDRA-6881. My basic argument is that once
you start turning a component CFMeta, StorageProxy to no longer be static you basically have
to turn everything un-static because the changes keep cascading. 

The approach here is to smart small by passing instances around even though they are still
the singleton and each progressive pass we get closer to a singleton free cassandra. It is
cosmetic to an extent, but soon when the StorageProxy is not a singleton any more these classes
will be written in a way that a StorageProxy can be passed to them. If you have some other
ideas let me know.


was (Author: appodictic):
[~iamaleksey] See my comment at the end of CASSANDRA-6881. My basic argument is that once
you start turning a component CFMeta, StorageProxy to no longer be static you basically have
to turn everything un-static because the changes keep cascading. 

The approach here is to smart small by passing instances around even though they are still
the singleton and each progressive pass we get closer to a singleton free cassandra. It is
cosmetic to an extent but soon when these StorageProxy is not a singleton anymore these classes
will be written in a way that a StorageProxy can be passed to them. If you have some other
ideas let me know.

> ReadExecutors should not rely on static StorageProxy
> ----------------------------------------------------
>
>                 Key: CASSANDRA-6985
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6985
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: CASSANDRA_6985.1.patch
>
>
> All the Read Executor child classes require use of the Storage Proxy to carry out read.
We can pass the StorageProxy along in the constructor.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message