cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6985) ReadExecutors should not rely on static StorageProxy
Date Sun, 13 Apr 2014 22:28:14 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967964#comment-13967964
] 

Aleksey Yeschenko commented on CASSANDRA-6985:
----------------------------------------------

I don't see how this patch improves anything for the better. It doesn't get rid of singletons,
it's purely cosmetic (StorageProxy itself remains a singleton). So, what is the point?

> ReadExecutors should not rely on static StorageProxy
> ----------------------------------------------------
>
>                 Key: CASSANDRA-6985
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6985
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: CASSANDRA_6985.1.patch
>
>
> All the Read Executor child classes require use of the Storage Proxy to carry out read.
We can pass the StorageProxy along in the constructor.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message