cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-6969) Use Unsafe Mutations Where Possible in Unit Tests
Date Tue, 01 Apr 2014 18:11:18 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956833#comment-13956833
] 

Benedict edited comment on CASSANDRA-6969 at 4/1/14 6:10 PM:
-------------------------------------------------------------

If this is the plan, why not just convert to periodic CL? I thought the reason we used Batch
CL in unit tests was to give it a bit of a run in case it happens to catch something? (Admittedly
not the most scientific of reasons, but if we're planning on disabling it everywhere, it does
seem like using Batch doesn't buy us much)


was (Author: benedict):
If this is the plan, why not just convert to periodic CL? I thought the reason we used Batch
CL in unit tests was to give it a bit of a run in case it happens to catch something?

> Use Unsafe Mutations Where Possible in Unit Tests
> -------------------------------------------------
>
>                 Key: CASSANDRA-6969
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6969
>             Project: Cassandra
>          Issue Type: Test
>          Components: Tests
>            Reporter: Tyler Hobbs
>            Assignee: Lyuben Todorov
>            Priority: Minor
>
> Since the test config uses the "batch" mode for the commitlog, safe writes are quite
slow.  In tests that don't rely on safe writes, we should use unsafe writes.  This mostly
consists of converting {{RowMutation.apply()}} calls into {{RowMutation.applyUnsafe()}} calls.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message