cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Bailey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6920) LatencyMetrics can return infinity
Date Thu, 03 Apr 2014 22:33:16 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959346#comment-13959346
] 

Nick Bailey commented on CASSANDRA-6920:
----------------------------------------

Well, the metric is deprecated. The same metric (essentiall) is exposed as the 1/5/15 minute
latency rates that metrics already exposes. Personally I don't think there is much difference
between returning 0 if we hit the race and returning infinity since both are wrong. Infinity
might even be better since it's more obviously wrong and easy to catch and work around.

Maybe we just document the issue and let it go away when we drop the old metrics in favor
of coda hale metrics.

> LatencyMetrics can return infinity 
> -----------------------------------
>
>                 Key: CASSANDRA-6920
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6920
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Nick Bailey
>            Assignee: Nick Bailey
>             Fix For: 1.2.17, 2.0.7, 2.1 beta2
>
>         Attachments: 6920-cassandra-1.2.patch, 6920-cassandra-2.0.patch, 6920-infinity-metrics.patch
>
>
> There is a race condition when updating the recentLatency metrics exposed from LatencyMetrics.
> Attaching a patch with a test that exposes the issue and a potential fix.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message