cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-6912) SSTableReader.isReplaced does not allow for safe resource cleanup
Date Tue, 01 Apr 2014 22:17:17 GMT


Tyler Hobbs commented on CASSANDRA-6912:

Overall this looks good.  The only part I'm not sure about is running the SSTableDeletingTask
and deleting the data/index files directly in tidy().  Instead of calling
directly, deletingTask.schedule() should be used to properly handle failures.  I believe there's
a similar problem with calling deleteWithConfirm() directly on the files; see the comment
near the top of SSTableDeletingTask.

Adding a comment to tidy() with your summary would also be good.

> SSTableReader.isReplaced does not allow for safe resource cleanup
> -----------------------------------------------------------------
>                 Key: CASSANDRA-6912
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Benedict
>            Assignee: Benedict
>             Fix For: 2.1 beta2
> There are a number of possible race conditions on resource cleanup from the use of cloneWithNewSummarySamplingLevel,
because the replacement sstable can be itself replaced/obsoleted while the prior sstable is
still referenced (this is actually quite easy with compaction, but can happen in other circumstances
less commonly).

This message was sent by Atlassian JIRA

View raw message