cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lyuben Todorov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6487) Log WARN on large batch sizes
Date Fri, 11 Apr 2014 22:04:19 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967165#comment-13967165
] 

Lyuben Todorov commented on CASSANDRA-6487:
-------------------------------------------

[~iamaleksey] I assume you mean calling {{ByteBuffer#limit}} in {{BatchStatement#executeWithPerStatementVariables}},
I like the idea, it will be much more accurate than just counting queries and it's just a
loop with a counter, and shouldn't hurt the fast path, right? /cc [~benedict]. 

bq. Maybe count of batch size warnings, largest batch size seen, most recent batch size over
the limit.
[~jkrupan] +1, maybe also something like total statement count over the limit (e.g. if a batch
exceeds the limit by 10, and this occurs 4 times, that metric will end up with 40). 

> Log WARN on large batch sizes
> -----------------------------
>
>                 Key: CASSANDRA-6487
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6487
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Patrick McFadin
>            Assignee: Lyuben Todorov
>            Priority: Minor
>             Fix For: 2.0.8
>
>         Attachments: 6487_trunk.patch, 6487_trunk_v2.patch, cassandra-2.0-6487.diff
>
>
> Large batches on a coordinator can cause a lot of node stress. I propose adding a WARN
log entry if batch sizes go beyond a configurable size. This will give more visibility to
operators on something that can happen on the developer side. 
> New yaml setting with 5k default.
> {{# Log WARN on any batch size exceeding this value. 5k by default.}}
> {{# Caution should be taken on increasing the size of this threshold as it can lead to
node instability.}}
> {{batch_size_warn_threshold: 5k}}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message