cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yu...@apache.org
Subject [1/3] git commit: Remove Closable from SSTableReader
Date Fri, 11 Apr 2014 16:33:40 GMT
Repository: cassandra
Updated Branches:
  refs/heads/cassandra-2.1 930905bbe -> 9d08e50da
  refs/heads/trunk 574468cba -> cbb3c8f48


Remove Closable from SSTableReader

to clarify the way to release resource held by SSTableReader


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/9d08e50d
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/9d08e50d
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/9d08e50d

Branch: refs/heads/cassandra-2.1
Commit: 9d08e50daaed83fc8e9321b6ae1d44f8e8137d8a
Parents: 930905b
Author: Yuki Morishita <yukim@apache.org>
Authored: Fri Apr 11 11:31:31 2014 -0500
Committer: Yuki Morishita <yukim@apache.org>
Committed: Fri Apr 11 11:31:31 2014 -0500

----------------------------------------------------------------------
 .../org/apache/cassandra/io/sstable/SSTableReader.java   | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/9d08e50d/src/java/org/apache/cassandra/io/sstable/SSTableReader.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/io/sstable/SSTableReader.java b/src/java/org/apache/cassandra/io/sstable/SSTableReader.java
index bc5002f..47d31b6 100644
--- a/src/java/org/apache/cassandra/io/sstable/SSTableReader.java
+++ b/src/java/org/apache/cassandra/io/sstable/SSTableReader.java
@@ -18,7 +18,6 @@
 package org.apache.cassandra.io.sstable;
 
 import java.io.BufferedInputStream;
-import java.io.Closeable;
 import java.io.DataInputStream;
 import java.io.File;
 import java.io.FileInputStream;
@@ -117,7 +116,7 @@ import static org.apache.cassandra.db.Directories.SECONDARY_INDEX_NAME_SEPARATOR
  * SSTableReaders are open()ed by Keyspace.onStart; after that they are created by SSTableWriter.renameAndOpen.
  * Do not re-call open() on existing SSTable files; use the references kept by ColumnFamilyStore
post-start instead.
  */
-public class SSTableReader extends SSTable implements Closeable
+public class SSTableReader extends SSTable
 {
     private static final Logger logger = LoggerFactory.getLogger(SSTableReader.class);
 
@@ -620,14 +619,6 @@ public class SSTableReader extends SSTable implements Closeable
         }
     }
 
-    /**
-     * Schedule clean-up of resources
-     */
-    public void close()
-    {
-        tidy(false);
-    }
-
     public String getFilename()
     {
         return dfile.path;


Mime
View raw message