Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A479110550 for ; Tue, 18 Mar 2014 16:32:51 +0000 (UTC) Received: (qmail 19375 invoked by uid 500); 18 Mar 2014 16:32:50 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 19276 invoked by uid 500); 18 Mar 2014 16:32:49 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 19245 invoked by uid 99); 18 Mar 2014 16:32:48 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Mar 2014 16:32:48 +0000 Date: Tue, 18 Mar 2014 16:32:48 +0000 (UTC) From: =?utf-8?Q?Piotr_Ko=C5=82aczkowski_=28JIRA=29?= To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-6311) Add CqlRecordReader to take advantage of native CQL pagination MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-6311?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 13939449#comment-13939449 ]=20 Piotr Ko=C5=82aczkowski commented on CASSANDRA-6311: ----------------------------------------------- {noformat} if (origHost !=3D null) + { + return Collections.singletonList(origHost).iterator(); + } + else + { + return liveRemoteHosts.iterator(); + } {noformat} This creates a race condition, if the origHost goes down immediately after = returning from this method, the list of hosts to try will be empty and the = query will fail. In the first branch, you should return origHost *and* live= RemoteHosts. > Add CqlRecordReader to take advantage of native CQL pagination > -------------------------------------------------------------- > > Key: CASSANDRA-6311 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6311 > Project: Cassandra > Issue Type: New Feature > Components: Hadoop > Reporter: Alex Liu > Assignee: Alex Liu > Fix For: 2.0.7 > > Attachments: 6311-v3-2.0-branch.txt, 6311-v4.txt, 6311-v5-2.0-bra= nch.txt, 6311-v6-2.0-branch.txt, 6311-v7.txt, 6311-v8.txt, 6331-2.0-branch.= txt, 6331-v2-2.0-branch.txt > > > Since the latest Cql pagination is done and it should be more efficient, = so we need update CqlPagingRecordReader to use it instead of the custom thr= ift paging. -- This message was sent by Atlassian JIRA (v6.2#6252)