Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 5 Mar 2014 16:50:43 +0000 (UTC)
From: "Edward Capriolo (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12672357.1380900475033.6615.1394038243384@arcas>
In-Reply-To: <JIRA.12672357.1380900475033@arcas>
References: <JIRA.12672357.1380900475033@arcas>
Subject: [jira] [Commented] (CASSANDRA-6147) Break timestamp ties for
 thrift-ers
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-6147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921033#comment-13921033 ] 

Edward Capriolo commented on CASSANDRA-6147:
--------------------------------------------

[~jbellis] You are right I kinda stole this ticket. The point of this patch is that if CQL can auto-timestamp things, thrift should be able to as well. Would you like me to open another ticket? Should the auto-timestamp be system.currentTimeMillis() + 1000? How does CQL arrive at its auto timestamp?

> Break timestamp ties for thrift-ers
> -----------------------------------
>
>                 Key: CASSANDRA-6147
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6147
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>             Fix For: 2.1 beta2
>
>
> Thrift users are still forced to generate timestamps on the client side. Currently the way the thrift bindings are generated users are forced to supply timestamps. There are two solutions I see.
> * -1 as timestamp means "generate on the server side"
> This is a breaking change, for those using -1 as a timestamp (which should effectively be no one.
> * Prepare yourself....
> Our thrift signatures are wrong, you can't overload methods in thrift
> thrift.get(byte [], byte[], ts) 
> should REALLY be changed to 
> GetRequest g =  new GetRequest()
> g.setName()
> g.setValue()
> g.setTs() ///optional 
> thrift. get( g )
> I know no one is going to want to make this change because thrift is quasi/dead but it would allow us to evolve thrift in a meaningful way. We could simple add these new methods under different names as well.


--
This message was sent by Atlassian JIRA
(v6.2#6252)