cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CASSANDRA-6947) SocketException being swallowed
Date Fri, 28 Mar 2014 14:25:18 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jonathan Ellis resolved CASSANDRA-6947.
---------------------------------------

    Resolution: Not A Problem

these are places where we have decided that the exception should not be fatal

> SocketException being swallowed
> -------------------------------
>
>                 Key: CASSANDRA-6947
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6947
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Ding Yuan
>         Attachments: trunk-socketExceptions.txt
>
>
> There are a few cases where a SocketException is swallowed. For example: in the following
code snippet in TCustomServerSocket.java, a SocketException is ignored even though the method
declares that TTransportException can be thrown. 
> {noformat}
>     public void listen() throws TTransportException
>     {
>         // Make sure not to block on accept
>         if (serverSocket != null)
>         {
>             try
>             {
>                 serverSocket.setSoTimeout(100);
>             }
>             catch (SocketException sx)
>             {
>                 logger.error("Could not set socket timeout.", sx);
>             }
>         }
>     }
> {noformat}
> Propose to thrown TTransportException on SocketExceptions. Attaching a patch against
trunk for review. Thanks!



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message