cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-6931) BatchLogManager shouldn't serialize mutations with version 1.2 in 2.1.
Date Mon, 31 Mar 2014 09:01:32 GMT


Sylvain Lebresne commented on CASSANDRA-6931:

It's a bit annoying to have to bump the minimum requirement to upgrade to 2.1 once again:
can't we just special case the 2.1 patch to use the 1.2 version for any node before 2.1 (which
would make the 2.0 patch unnecessary as a bonus,  not that the 2.0 patch is extremely complex)?

> BatchLogManager shouldn't serialize mutations with version 1.2 in 2.1.
> ----------------------------------------------------------------------
>                 Key: CASSANDRA-6931
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Sylvain Lebresne
>            Assignee: Aleksey Yeschenko
>             Fix For: 2.1 beta2
> BatchLogManager serialize and deserialize mutations using MessagingService.VERSION_12
and this is hardcoded. Meaning that it does that in 2.0, 2.1 and trunk, even though in 2.1
the 1.2 format is not properly serialized properly since [this commit|]
(meaning that I'm pretty sure batch logs on super columns is broken on 2.1 currently). And
keeping the 1.2 format indefinitely just for batchlog is unrealistic.
> So batchlog needs to do something like hints, record the messaging format used to encode
every mutation and use that for deserialization, but always serialize with the current format.

This message was sent by Atlassian JIRA

View raw message